Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PRQL - SQL Output panel to SQL Preview #46

Closed
RandomFractals opened this issue Feb 4, 2023 · 1 comment
Closed

Rename PRQL - SQL Output panel to SQL Preview #46

RandomFractals opened this issue Feb 4, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@RandomFractals
Copy link
Collaborator

and use standard vscode $(open-preview) icon with SQL Preview webview panel title to display generated SQL code.

This would ensure we are using standard vscode icon and nomenclature for the Preview panel.

The corresponding command id would change to prql.openSqlPreview. Most extensions use ext. name as namespace, . for the command, view, or setting name separator and camel case for the names of those objects.

Below is the demo of new SQL Preview command, icon and Preview display. We can drop PRQL part from the preview panel title because it's clear that the panel is created by the PRQL extension as indicated by the panel icon in its titlebar.

Let's decide on what Create SQL Document or Compile to SQL and Run should look like in #42.

The proposed changes below should take care of standardizing auto-updated SQL Preview.

prql-sql-preview

@max-sixty
Copy link
Member

Closing from #47. Excellent idea!

@RandomFractals RandomFractals added the enhancement New feature or request label Feb 8, 2023
@RandomFractals RandomFractals self-assigned this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants