Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for different DBs in CI #2211

Closed
Jelenkee opened this issue Mar 17, 2023 · 1 comment · Fixed by #2286
Closed

Integration test for different DBs in CI #2211

Jelenkee opened this issue Mar 17, 2023 · 1 comment · Fixed by #2286
Labels

Comments

@Jelenkee
Copy link
Contributor

What's up?

Hi,
I noticed that there is an integration test with SQLite, DuckDB and Postgres that does not run in CI. Is there a special reason for that?

I think it would be cool to run tests for different vendors like MySQL (or MariaDB) in CI as well. Even IBM DB2 and MS SQL Server have public docker images that can be used.
The tests should cover the syntactic/semanctic differences between theses vendors (like SUBSTR vs SUBSTRING) so that issues like #1854 can be discovered earlier.

We can adapt the workflow from objection.js which looks pretty simple
workflow
docker-compose

It may not be necessary to fill the DBs with chinook before testing. Just a few records in a table may be enough.

@max-sixty
Copy link
Member

Great, thanks for the issue @Jelenkee

I think that we do run the SQLite & DuckDB tests in CI — they run as part of cargo test, because they can run in-process — i.e. no need to run a separate executable.

We could definitely run tests in CI for other DBs with docker-compose, and this will become increasingly useful as we develop more dialect-specific features. One nice feature about docker-compose is that they're also fairly easy to run locally, and we can add a single command to task test-all to have those run as part of that.

@max-sixty max-sixty changed the title Integration test for different vendors in CI Integration test for different DBs in CI Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants