Schema name in Postgres from is incorrectly quoted

[mklopets]

This behaviour was introduced in #809

Assume you have a Postgres database with a schema some_schema (this could even be public)

prql dialect:postgres
from some_schema.tablename

compiles to

SELECT
  some_schema.tablename.*
FROM
  "some_schema.tablename"

which is an invalid query – the schema name shouldn't be inside quotes (postgres will complain with relation "some_schema.tablename" does not exist.

If we want to keep the quotes, a valid Postgres query would be:

-  "some_schema.tablename"
+  "some_schema"."tablename"

or just

-  "some_schema.tablename"
+  some_schema.tablename

[max-sixty]

Ah, this is unfortunate, #809 was quite elegant. We can make it split by . I think.

Does this block you? We can revert #809 if it does (we have a policy of fast merges and fast reverts!)

[mklopets]

it's non-blocking until prql-js has a new version we need to update to for other reasons (the latest published version, v0.2.2 is fine)

splitting by . would be neat, though I'm not sure which other dialects this applies to

[max-sixty]

OK. Probably we should revert rather than block a release, but let me see whether it's an easy fix

[blackary]

Similar issue with BigQuery

prql dialect:bigquery
from db.schema.table

->

SELECT
  db.schema.table.*
FROM
  `db.schema.table`

Which causes this error:
Unrecognized name: db at [2:3]

In this case the backticks after the FROM are fine, but they are missing after the SELECT

-  db.schema.table.*
+  `db.schma.table`.*

[huw]

This is also breaking Spark SQL (not a supported dialect, I know)—in this case, the FROM clause needs a table name of either some_schema.tablename or

`some_schema`.`tablename`

(Seems like it would be ideal to split on . in all dialects, regardless of quote marks).

[max-sixty]

Closed by #838. Thanks for everyone's patience