New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set options$engine
to support quarto 1.3
#110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good. You just need to check that changing the option here does not have side effect with knitr::knit_engines$get("sql")
that you use after.
I don't think so.
options$lang <- options$lang %||% "elm" | ||
|
||
# Workaround for Quarto CLI 1.3 | ||
# https://github.com/quarto-dev/quarto-cli/pull/4735 | ||
options$engine <- "elm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to be complete in your workaround, you probably need to use
options$engine <- options$lang
in case a user has change the lang
option . Otherwise it won't apply
Don't you think ?
options$lang <- options$lang %||% "elm" | |
# Workaround for Quarto CLI 1.3 | |
# https://github.com/quarto-dev/quarto-cli/pull/4735 | |
options$engine <- "elm" | |
options$lang <- options$lang %||% "elm" | |
# Workaround for Quarto CLI 1.3 | |
# https://github.com/quarto-dev/quarto-cli/pull/4735 | |
options$engine <- options$lang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion!
I will add a test to make sure lang
changes are possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the lang
option is respected by the knitr::knit()
function even without this change.
Is there any possibility that fixing engine to "elm"
will cause any problems?
Fix #109
See also quarto-dev/quarto-cli#4735