Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix python versions #165

Merged
merged 3 commits into from Apr 2, 2023
Merged

fix: fix python versions #165

merged 3 commits into from Apr 2, 2023

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Apr 2, 2023

IPython is not supporting python 3.7

@eitsupi eitsupi changed the title fix: fix python version in pyproject.toml fix: fix python version in pyproject.toml (used by poetry) Apr 2, 2023
@eitsupi eitsupi changed the title fix: fix python version in pyproject.toml (used by poetry) fix: fix python versions Apr 2, 2023
@eitsupi eitsupi merged commit fb70408 into PRQL:main Apr 2, 2023
13 checks passed
@eitsupi eitsupi deleted the fix-python-version branch April 2, 2023 03:06
@max-sixty
Copy link
Member

Yes, I think even 3.8 is close to losing support in some packages... Thanks

@eitsupi
Copy link
Member Author

eitsupi commented Apr 2, 2023

I happened to be reading the GitHub Actions log and noticed this, I think the step to set up poetry is too clever for this use case.
Probably better to check it some other way.

https://github.com/PRQL/pyprql/pull/164/checks#step:5:14

The currently activated Python version 3.7.16 is not supported by the project (^3.8).
Trying to find and use a compatible version. 
Using python3.10 (3.10.6)
Creating virtualenv pyprql-2JuVSC4c-py3.10 in /home/runner/.cache/pypoetry/virtualenvs
Installing dependencies from lock file

@max-sixty
Copy link
Member

Hmmm. I had tried to make it simple — it used to rely on nox.

I think we should only have that problem when it's an incompatible version, which is rare...

But ofc open to any changes!

@max-sixty
Copy link
Member

BTW it's also fine to cut out the "middle" version if we want to reduce the testing burden. It's extremely unlikely that something would fail on 3.9 if it passes on 3.8 & 3.10...

@eitsupi
Copy link
Member Author

eitsupi commented Apr 2, 2023

BTW it's also fine to cut out the "middle" version if we want to reduce the testing burden. It's extremely unlikely that something would fail on 3.9 if it passes on 3.8 & 3.10...

Definitely!
Perhaps one number for the minimal version (e.g. 3.8) and something like 3.x will suffice.
https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#matrix-testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants