ACTC_c / CTC_c relationship

[hdoupe]

I just noticed that tests are failing on master when running reform 41 in reforms.json:

Tax-Calculator/taxcalc/tests/reforms.json

Lines 412 to 419 in 0a4bc06

	"41": {
	"baseline": "2017_law.json",
	"start_year": 2015,
	"value": {"CTC_c": 0},
	"name": "Eliminate child tax credit",
	"output_type": "iitax",
	"compare_with": {"Tax Expenditure": [57.3, 57.0, 57.1, 56.8]}
	},

This error makes sense because ACTC_c must be less than CTC_c:

Tax-Calculator/taxcalc/policy_current_law.json

Lines 13809 to 13814 in 0a4bc06

	"validators": {
	"range": {
	"min": 0,
	"max": "CTC_c"
	}
	},

But CTC_c doesn't have a similar range validator which is why the error wasn't triggered before:

Tax-Calculator/taxcalc/policy_current_law.json

Lines 13457 to 13462 in 0a4bc06

	"validators": {
	"range": {
	"min": 0,
	"max": 9e+99
	}
	},

The reason this error is being thrown now is that all parameter values are validated after #2532 -- not just the parameters that were updated. Before, the validation logic didn't check whether the value of ACTC_c was valid after CTC_c was validated. Now it does.

To fix this, we can update reform 41 to be:

"41": {
    "baseline": "2017_law.json",
    "start_year": 2015,
    "value": {"CTC_c": 0, "ACTC_c": 0},
    "name": "Eliminate child tax credit",
    "output_type": "iitax",
    "compare_with": {"Tax Expenditure": [57.3, 57.0, 57.1, 56.8]}
},

[MattHJensen]

Thanks @hdoupe.