Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joss-review] reduce sampling time for example run #26

Open
zonca opened this issue Apr 24, 2024 · 3 comments
Open

[joss-review] reduce sampling time for example run #26

zonca opened this issue Apr 24, 2024 · 3 comments

Comments

@zonca
Copy link

zonca commented Apr 24, 2024

Running the example on a A100 took almost 4 hours.

Do you think it would be possible to add a limit on the sampling so that it just runs for 30 min or so?
then you can explain how to change that parameter to run until completion.

@jburba
Copy link
Collaborator

jburba commented May 3, 2024

There is a way to restrict the number of samples (by setting the max_iter kwarg in pymultinest.run for example). But, I'd have to experiment with how few samples you can get away with while maintaining reasonably resolved posteriors. If we want to implement some sort of test of the results as suggested in #21, for example, we'll need to have decent posteriors.

It is in principle possible to trim the test dataset such that the number of model parameters is smaller. The run time of the code is dominated by the Cholesky decomposition which scales as the number of model parameters cubed. We've talked about this in the past, but at the same time, this dataset and model size is already greatly reduced from what an analysis of real (not simulated) data from an interferometer will require.

@zonca
Copy link
Author

zonca commented May 3, 2024

I think you could set max_iter to have the test run for 30 min, then you put a very easy test on the posterior, we are just looking that the software is not wrong by orders of magnitude.
It is a test on the software, not a scientific-level test you would do for a paper.

@musoke
Copy link

musoke commented May 31, 2024

we are just looking that the software is not wrong by orders of magnitude.
It is a test on the software, not a scientific-level test you would do for a paper.

Agreed - even a test that runs through the whole pipeline with extremely minimal parameters like maxiter=2 would be helpful for an initial check. Just to verify that everything is installed correctly, it can find the GPU, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants