New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite inverse methods of model estimation #189
Rewrite inverse methods of model estimation #189
Conversation
Codecov Report
@@ Coverage Diff @@
## prepare_major_release_2.0.0 #189 +/- ##
===============================================================
+ Coverage 49.72% 52.34% +2.62%
===============================================================
Files 24 24
Lines 1798 1790 -8
Branches 315 319 +4
===============================================================
+ Hits 894 937 +43
+ Misses 818 760 -58
- Partials 86 93 +7
Continue to review full report at Codecov.
|
Before I start to work on LSFIR and the others it would be great if @mgrub @eichstaedtPTB we could take a peek together (do a line by line code review) and you could give some feedback on the approaches I have chosen. I will adress this on next tuesday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great and extensive work!
Is there a reason, that the testing of the model_estimation
-module is done in test_identification.py
? Would a cosmetic change to test_model_estimation.py
be suitable?
…sis test" This reverts commit 673b79f.
…FIR_unc to filter coefficients
…_comparison Improve random covariance check for positive semi-definiteness
…r_fitting_H_directly): remove _
…nto refactor_and_finally_finish_implementation
…nto refactor_and_finally_finish_implementation # Conflicts: # test/test_LSFIR.py
…reciprocal with uncertainties BREAKING CHANGE: Combine _deconvolution.fit_filter_ and _identification.fit_filter_ into _model_estimation.fit_filter_ and provide access to all functionality via according parameter sets for _model_estimation.fit_filter.LSFIR_ and _model_estimation.fit_filter.LSIIR_.
This will finally resolve #147.
Merge and rewrite
Checkout the docs as well to be sure they look nicely: https://pydynamic.readthedocs.io/en/fix-147_rewrite_inverse_methods_of_model_estimation