convolve_unc allow 1D input arrays for uncertainty #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrub
requested review from
anupam-prasad
and removed request for
eichstaedtPTB
mgrub
commented
Mar 30, 2022
anupam-prasad
requested changes
Mar 30, 2022
suggested by @anupam-prasad
suggested by @anupam-prasad
suggested by @anupam-prasad
suggested by @anupam-prasad
Changes should be included now. |
anupam-prasad
approved these changes
Apr 1, 2022
- better expresses that it mainly distinguishes between None/np.ndarray suggested by @BjoernLudwigPTB
- use np.squeeze(a) instead of a.squeeze() to also support list or tuple
Codecov Report
@@ Coverage Diff @@
## rename_master_to_main #278 +/- ##
=========================================================
- Coverage 77.29% 76.68% -0.61%
=========================================================
Files 29 29
Lines 2233 2239 +6
Branches 361 362 +1
=========================================================
- Hits 1726 1717 -9
- Misses 381 393 +12
- Partials 126 129 +3
Continue to review full report at Codecov.
|
co-authored by @BjoernLudwigPTB
co-authored by @BjoernLudwigPTB
…lementation" This reverts commit ec401dc.
This reverts commit c26b035.
This reverts commit 0c133f5.
This reverts commit 2458630.
This reverts commit e196cc4.
|
The failed check in the preview job is no problem, as long as we merge first into the rename branch as suggested and configured. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For convenience, this implements the use of 1D-arrays for
U1andU2inPyDynamic.uncertainty.convolve_uncto specify the standard uncertainties instead of full covariance matrices.Specification of uncertainties using full covariance matrices remains possible and the output is still returned as full covariance matrix. Hence, no breaking change is introduced.
This PR makes required changes on: