Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Remove battle animations #159

Open
JuliusBooth opened this issue Dec 28, 2023 · 1 comment
Open

[Suggestion] Remove battle animations #159

JuliusBooth opened this issue Dec 28, 2023 · 1 comment

Comments

@JuliusBooth
Copy link

Skipping battle animations would probably speed up training ~5%. There is a setting in the game to do that.

There are also a lot of animation/pokemon frame combinations that might lead to a lot of (perhaps unintentional) screen exploration reward.

@w531t4
Copy link

w531t4 commented Dec 30, 2023

@JuliusBooth Regarding your comment about animation/pokemon frame combinations that lead to extra reward.. i've removed all battles from rewards and see promising results. It doesn't address the in-game setting, but it's a good idea.

...
        # The screen transitions (prior to battle) seem to be encouraging
        # it to go into battle more often. 0xd057 is non-zero when in battle
        # (and during transitions).
        battle_indicator = self.read_m(0xD057)
...
        if battle_indicator == 0:
            if self.use_screen_explore:
                self.update_frame_knn_index(obs_flat)
            else:
                self.update_seen_coords(location=location)
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants