Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local setting Load Production Certificate #66

Open
ghachey opened this issue Dec 5, 2022 · 11 comments
Open

Remove local setting Load Production Certificate #66

ghachey opened this issue Dec 5, 2022 · 11 comments
Labels
enhancement New feature or request

Comments

@ghachey
Copy link
Collaborator

ghachey commented Dec 5, 2022

This setting is no longer required as both the production and development service account keys are loaded from the centralized configuration. Verify it is in fact no longer used and remove.

@ghachey ghachey added enhancement New feature or request help wanted Extra attention is needed labels Apr 19, 2023
@ghachey ghachey changed the title Remove local setting Load Production Certificate [2023] Remove local setting Load Production Certificate Apr 19, 2023
@ghachey
Copy link
Collaborator Author

ghachey commented Nov 27, 2023

@maratomega Please share progress on this one.

@maratomega
Copy link
Collaborator

@ghachey if we will remove this certificate, the app will crash if the user won't have the internet connection. Tested on our side without internet, it crashes once the user selects the country.
We can keep this cert without any harm, but if you require us to remove it we will need to show some error pop-up

Please share your thoughts.

@ghachey
Copy link
Collaborator Author

ghachey commented Nov 30, 2023

@maratomega ok we can keep. But it looks like an old key. Can you try replacing the key with the one I sent you through Skype.

I believe the place to replace is app/src/main/assets/c_dev.json

And see if it still all behaves correctly. Also, this could be related to issue #68 as this old server_account key is from the "Education Survey Tool Base" project. Is this key used in any way once the country is selected and a production key retrieved?

@ghachey
Copy link
Collaborator Author

ghachey commented Dec 14, 2023

In meeting it was discussed that:

@ghachey ghachey removed the help wanted Extra attention is needed label Dec 14, 2023
@ghachey
Copy link
Collaborator Author

ghachey commented May 6, 2024

@maratomega what is the progress on this?

@maratomega
Copy link
Collaborator

Completed

@ghachey
Copy link
Collaborator Author

ghachey commented May 7, 2024

@maratomega I installed the latest build and I still see in the settings "Load PRoduction Certificate", is there a reason why this local settings is still there? I thought you said this issue is complete, can you elaborate a little?

@maratomega
Copy link
Collaborator

@ghachey we haven't removed from the settings "Load Production Certificate" because of issues with the internet connection, it prevents the app from crashing.

@ghachey
Copy link
Collaborator Author

ghachey commented May 7, 2024

@maratomega I thought you said following the approach of per country builds would no longer require this old key to keep the app from crashing without Internet?

@maratomega
Copy link
Collaborator

@maratomega I thought you said following the approach of per country builds would no longer require this old key to keep the app from crashing without Internet?

During the testing without it, on the per country builds, we still had that issue.

@ghachey
Copy link
Collaborator Author

ghachey commented May 7, 2024

@maratomega I thought you said following the approach of per country builds would no longer require this old key to keep the app from crashing without Internet?

During the testing without it, on the per country builds, we still had that issue.

Can you at least hide the config from the user local settings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants