-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove local setting Load Production Certificate #66
Comments
@maratomega Please share progress on this one. |
@ghachey if we will remove this certificate, the app will crash if the user won't have the internet connection. Tested on our side without internet, it crashes once the user selects the country. Please share your thoughts. |
@maratomega ok we can keep. But it looks like an old key. Can you try replacing the key with the one I sent you through Skype. I believe the place to replace is app/src/main/assets/c_dev.json And see if it still all behaves correctly. Also, this could be related to issue #68 as this old server_account key is from the "Education Survey Tool Base" project. Is this key used in any way once the country is selected and a production key retrieved? |
In meeting it was discussed that:
|
@maratomega what is the progress on this? |
Completed |
@maratomega I installed the latest build and I still see in the settings "Load PRoduction Certificate", is there a reason why this local settings is still there? I thought you said this issue is complete, can you elaborate a little? |
@ghachey we haven't removed from the settings "Load Production Certificate" because of issues with the internet connection, it prevents the app from crashing. |
@maratomega I thought you said following the approach of per country builds would no longer require this old key to keep the app from crashing without Internet? |
During the testing without it, on the per country builds, we still had that issue. |
Can you at least hide the config from the user local settings? |
This setting is no longer required as both the production and development service account keys are loaded from the centralized configuration. Verify it is in fact no longer used and remove.
The text was updated successfully, but these errors were encountered: