Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line 32: The best overload for 'ExecuteReader' does not have a parameter 'parameterValues' #2

Open
VladimirNikashin opened this issue Mar 11, 2020 · 0 comments

Comments

@VladimirNikashin
Copy link

using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Internal;
using Microsoft.EntityFrameworkCore.Storage;
using Microsoft.Extensions.DependencyInjection;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using System.Data.SqlClient;
using System.Data.Common;
using System.Reflection;

namespace MasteringEFCore.RawSql.Final.Extensions
{
public static class DatabaseExtensions
{
public static RelationalDataReader ExecuteSqlQuery(this DatabaseFacade databaseFacade, string sql, params object[] parameters)
{
var concurrencyDetector = databaseFacade.GetService();

        using (concurrencyDetector.EnterCriticalSection())
        {
            var rawSqlCommand = databaseFacade
                .GetService<IRawSqlCommandBuilder>()
                .Build(sql, parameters);

            return rawSqlCommand
                .RelationalCommand
                .ExecuteReader(
                    databaseFacade.GetService<IRelationalConnection>(), parameterValues: rawSqlCommand.ParameterValues);
        }
    }

    public static async Task<RelationalDataReader> ExecuteSqlQueryAsync(this DatabaseFacade databaseFacade,
                                                         string sql,
                                                         CancellationToken cancellationToken = default(CancellationToken),
                                                         params object[] parameters)
    {

        var concurrencyDetector = databaseFacade.GetService<IConcurrencyDetector>();

        using (concurrencyDetector.EnterCriticalSection())
        {
            var rawSqlCommand = databaseFacade
                .GetService<IRawSqlCommandBuilder>()
                .Build(sql, parameters);

            return await rawSqlCommand
                .RelationalCommand
                .ExecuteReaderAsync(
                    databaseFacade.GetService<IRelationalConnection>(), 
                    parameterValues: rawSqlCommand.ParameterValues, 
                    cancellationToken: cancellationToken);
        }
    }
}

}

line 32: The best overload for 'ExecuteReader' does not have a parameter 'parameterValues'
Any ideas on how to fix the above error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant