-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for viewBox #12
Comments
I've got a working (for the handful of SVGs I've tried it with) implementation on my fork. I'm not sure if the parsing out of the numbers in the Also having a brain fade on running the tests. How should I be trying to run them? I'm getting an error at the moment...
Happy to submit a PR once I've worked out how to test things 😀 |
Hey, thank you for doing all this! I really should do a better job of documenting the testing process 😅. In this case, I'm guessing the issue is that the working directory is named Let me know if you have any luck. |
Thanks. Seems to need me to add the repo's root folder to my Will fix that, and find an example of the viewbox stuff later. |
How odd, I wonder why that would be. Glad the tests are doing their job though. Good luck! |
Hey there, any success with view boxes? |
Hello! Got snowed under with other stuff, so hadn't had chance to pull together a test file until today. Running the tests it fails on Mindful of submitting a PR to fix too many issues (and on getting sidelined before I get the PR submitted) I'll submit one to fix both this and #13 anyway, with the failing (I can work them up into separate PRs if need be, but it'll need to annoying git wrangling I'm hoping I can get away without 😁) |
(feature request) At present the
viewBox
attribute of thesvg
elements is ignored, which can result in things ending up the wrong size.The text was updated successfully, but these errors were encountered: