Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code: Get rid of file suffixes in the code #71

Closed
kai-li-wop opened this issue Apr 15, 2021 · 3 comments
Closed

Code: Get rid of file suffixes in the code #71

kai-li-wop opened this issue Apr 15, 2021 · 3 comments
Assignees
Milestone

Comments

@kai-li-wop
Copy link
Member

There are still extensions like TGA and WAV in the hardcoded paths to textures and soudfiles, which cause files in OGG and PNG format not to be included automatically, for example player icons in the menu. Now I did not want to do this myself, because I do not know if this can also break something if you do it globally. I would have liked to implement this already now in v1.6.1, because then in the meantime e.g. player models can be released as addon for WoP from the community, which already contain PNGs and then remain also compatible for WoP v1.7, provided that we do not make further fundamental path adjustments with the player models.

@mgerhardy
Copy link
Member

In general the extensions are stripped and not taken into account - if there are locations where they are used, please let me know the exact issue - otherwise we would most likely modify almost every source file and would diverge from ioq3 a lot.

@kai-li-wop
Copy link
Member Author

kai-li-wop commented Apr 18, 2021

I just tested by adding a png icon of a custom player model and it was shown in the players menu correctly. In WoP 1.6 it was already possible to use png in maps or such format, but not in the menu for player icons. I need to more concrete here: The issue applies to the player skins selection buttons, not the player model selections buttons. See PadWorld-Entertainment/worldofpadman-fork#63

@kai-li-wop
Copy link
Member Author

I think this can be closed as all related PRs got merged, If not, reopen.

mgerhardy referenced this issue in PadWorld-Entertainment/worldofpadman-fork May 2, 2021
removing the wav extension as given in issue ioquake#35
@kai-li-wop kai-li-wop transferred this issue from PadWorld-Entertainment/worldofpadman-fork Dec 6, 2021
@kai-li-wop kai-li-wop added this to the v1.6.1 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants