Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CUDA code from dim.h #2510

Closed
wangkuiyi opened this issue Jun 19, 2017 · 1 comment
Closed

Remove CUDA code from dim.h #2510

wangkuiyi opened this issue Jun 19, 2017 · 1 comment
Assignees

Comments

@wangkuiyi
Copy link
Collaborator

It seems that caffe2::TensorShape and other tensor shape constraints are not supposed to be used in CUDA kernels. Does this mean that we can remove the CUDA code generation macros from dim.h?

@JiayiFeng
Copy link
Collaborator

dim serve not only as tensor shape but also as element index. In the second case, It may be used in our hand-written CUDA kernels.
Actually, it costs few to implement CUDA supporting in dim, only a few macros and function prefixes. So I tend to keep them for now. If they are turned out to be unnecessary in the future, removing them will also be an easy task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants