Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we remove ProtoDataProvider related code? #3554

Closed
luotao1 opened this issue Aug 17, 2017 · 1 comment
Closed

Can we remove ProtoDataProvider related code? #3554

luotao1 opened this issue Aug 17, 2017 · 1 comment

Comments

@luotao1
Copy link
Contributor

luotao1 commented Aug 17, 2017

Can we remove ProtoDataProvider related codes? Several reasons are as follows:

  • ProtoDataProvider has not been used for a long time, and we don't give continuous support and maintenance for it since PaddlePaddle open source.
  • In v2 API, we read data using Python API. In v1 API, we read data using PyDataProvider.

@qingqing01 @reyoung @wangkuiyi How do you think about it?

@luotao1
Copy link
Contributor Author

luotao1 commented Nov 29, 2017

solved by #5345 and #5775

@luotao1 luotao1 closed this as completed Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant