Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in RecurrentGradienMachine's fillGenOutputs #3673

Closed
wangkuiyi opened this issue Aug 24, 2017 · 1 comment
Closed

Bug in RecurrentGradienMachine's fillGenOutputs #3673

wangkuiyi opened this issue Aug 24, 2017 · 1 comment

Comments

@wangkuiyi
Copy link
Collaborator

When numResults == 1, path.ids are wrongly inserted into the beginning of generator_.ids. This is fine if the batchSize == 1, but will have an reverse batch if batchSize > 1. The .begin() should be changed to .end(). The original code '.begin()' must be a typo.

@wangkuiyi
Copy link
Collaborator Author

This issue has been fixed by #3647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant