Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine ExpandConvLayer.cpp #4128

Closed
hedaoyuan opened this issue Sep 15, 2017 · 0 comments
Closed

Refine ExpandConvLayer.cpp #4128

hedaoyuan opened this issue Sep 15, 2017 · 0 comments

Comments

@hedaoyuan
Copy link
Contributor

Based on previous code refactoring #2282, the file ExpandConvTransLayer has been removed. By further refactoring the convolution layer of im2col + gemm, we can remove the ExpandConvBaseLayer file.

  • The addSharedBias and bpropSharedBias implementation in the ExpandConvBaseLayer is less performance, we can use Matrix::addSharedBias and Matrix::collectSharedBias to replace.
  • After removing the four functions related to the bias operation, ExpandConvBaseLayer has only one init function, so we can further refactor to remove this class.
@hedaoyuan hedaoyuan self-assigned this Sep 15, 2017
@hedaoyuan hedaoyuan added this to Convolution Optimization in Embedded and Mobile Deployment Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Embedded and Mobile Deployment
Convolution Optimization
Development

No branches or pull requests

1 participant