Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The seq_concat_op should correctly process LoD since the meaning of LoD has been changed. #5039

Closed
qingqing01 opened this issue Oct 24, 2017 · 0 comments
Closed

The seq_concat_op should correctly process LoD since the meaning of LoD has been changed. #5039

qingqing01 opened this issue Oct 24, 2017 · 0 comments
Assignees
@Yancey1989

Comments

@qingqing01
Copy link
Contributor

The issue#4945 change LoD's absolute offsets to relative offsets, especially for the more than 1 level sequence. So the seq_concat_op should correctly process LoD and update the unit testing: https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/v2/framework/tests/test_seq_concat_op.py#L11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yancey1989 Yancey1989

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Yancey1989 @qingqing01