New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ProtoData in config_parser.py #5769

Closed

luotao1 opened this issue Nov 20, 2017 · 0 comments · Fixed by #5775

Assignees

Contributor

luotao1 commented Nov 20, 2017 •

edited

Loading

related to #5344 :
We can remove unused ProtoData in config_parser.py, and there are some related files which should be updated:

test_config.conf in config_parser_test.py: use SimpleData to replace ProtoData
chunking.conf in test_Trainer.cpp: can we remove this config since we should gen_proto_data in CMakeLists.txt.
compare_sparse_data: forgot to delete in remove usused ProtoDataProvider related codes #5344

The text was updated successfully, but these errors were encountered:

luotao1 self-assigned this

luotao1 mentioned this issue

remove ProtoData #5775

Merged

luotao1 closed this as completed in #5775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment