Failed to build feature_value_test.cc in Release/2.6 (8189a99)

[jeng1220]

问题描述 Issue Description

Build release/2.6 branch but triggers following error if -DWITH_TESTING=ON.
After manually resolving #60088, it triggers another error:

FAILED: test/CMakeFiles/feature_value_test.dir/__/paddle/fluid/distributed/test/feature_value_test.cc.o
...
/workspace/paddle/paddle/fluid/distributed/common/chunk_allocator.h:80:19: error: ignoring return value of 'int posix_memalign(void**, size_t, size_t)' declared with attribute 'warn_unused_result' [-Werror=unused-result]
   80 |     posix_memalign(reinterpret_cast<void**>(&chunk),
      |     ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   81 |                    std::max<size_t>(sizeof(void*), alignof(Chunk)),
      |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   82 |                    sizeof(Chunk) + sizeof(Node) * _chunk_size);
      |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

It's better to take a closer look before force-disabling -Werror=unused-result.

版本&环境信息 Version & Environment Information

CCACHE_DIR=/workspace/ccache_storage
ARCH_FLAGS="-march=sandybridge -mtune=broadwell"
CXX_FLAGS="$ARCH_FLAGS -Wno-error=range-loop-construct -Wno-error=maybe-uninitialized -Wno-error=switch -faligned-new=32"
CUDA_FLAGS="-t2 --forward-unknown-to-host-compiler -Xfatbin=-compress-all $ARCH_FLAGS -lineinfo"

SKIP_DOWNLOAD_INFERENCE_DATA=ON cmake -Bpaddle/build -Spaddle \
    -GNinja \
    -DINFERENCE_DEMO_INSTALL_DIR=/home/scratch.rjeng_sw/baidu/paddle/test_data \
    -DCMAKE_CXX_FLAGS="$CXX_FLAGS" \
    -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
    -DCMAKE_BUILD_TYPE=Release \
    -DCMAKE_CUDA_FLAGS="$CUDA_FLAGS" \
    -DCUDA_ARCH_NAME=Manual \
    -DCUDA_ARCH_BIN="80" \
    -DWITH_INCREMENTAL_COVERAGE=OFF \
    -DWITH_INFERENCE_API_TEST=OFF \
    -DWITH_DISTRIBUTE=ON \
    -DWITH_COVERAGE=OFF \
    -DWITH_TENSORRT=OFF \
    -DWITH_TESTING=ON \
    -DWITH_CONTRIB=ON \
    -DWITH_ROCM=OFF \
    -DWITH_RCCL=OFF \
    -DWITH_STRIP=ON \
    -DWITH_MKL=OFF \
    -DWITH_AVX=OFF \
    -DWITH_GPU=ON \
    -DWITH_PYTHON=ON \
    -DWITH_CUDNN_FRONTEND=ON \
    -DPY_VERSION=$PYVER \
    -Wno-dev

cmake --build paddle/build -j$((`nproc`))

• GCC 11.4.0

[jeng1220]

cc @onecatcn for vis

[haohongxiang]

您好，辛苦提供更多的版本&环境信息，如CUDA/Python/CMake version

[jeng1220]

@haohongxiang ,
這和CUDA/Python/CMake版本沒關係
是那段代碼設計確實有風險
看 posix_memalign 說明文檔
若 posix_memalign 返回 0 才代表有正確配置內存
反之代表配置失敗，例如alignment設定不正確等造成配置失敗
然而 chunk_allocator.h:80 並沒有檢查返回值
所以GCC依據-Werror=unused-result回報錯誤

[danleifeng]

您好，感谢您的指正，已经提pr修复这个问题了：#60208

[jeng1220]

@danleifeng ,
能麻煩 cherry-pick 到 release/2.6 分支嗎?

[tianshuo78520a]

@danleifeng , 能麻煩 cherry-pick 到 release/2.6 分支嗎?

#60495

[jeng1220]

感謝感謝