Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DataLayout into FourDimImageTensorDataLayout #8298

Closed
wangkuiyi opened this issue Feb 9, 2018 · 4 comments
Closed

Rename DataLayout into FourDimImageTensorDataLayout #8298

wangkuiyi opened this issue Feb 9, 2018 · 4 comments

Comments

@wangkuiyi
Copy link
Collaborator

wangkuiyi commented Feb 9, 2018

We have an enum type called DataLayout

enum class DataLayout {
kNHWC = 0,
kNCHW = 1,
kAnyLayout = 2,
};

and we have a property DataLayout Tensor::layout_.

The reason that we made this design is that we hope that for those tensors that represent images, we could have additional information describing the meaning of its dimensions.

However, we noticed that it is not a good idea to add the property layout_ to class Tensor. Instead, we should create a new C++ class ImageTensor derived from Tensor. For more details, please see the following comments:

@wangkuiyi wangkuiyi changed the title Rename DataLayout Rename DataLayout into FourDimImageTensorDataLayout Feb 9, 2018
@wangkuiyi
Copy link
Collaborator Author

wangkuiyi commented Feb 9, 2018

If we are going to have a data type, which represents an image, we should define a new C++ class as follows:

class ImageTensor : public Tensor {
 public:
  enum Layout {
    UNKNOWN = 0,
    NHWC = 1,
    HWNC = 2,
    ...
  };

 private:
  Layout layout_;
};

@wangkuiyi
Copy link
Collaborator Author

wangkuiyi commented Feb 9, 2018

Also, we need to update the framework.proto file

message VarDesc {
enum VarType {
LOD_TENSOR = 1;
SELECTED_ROWS = 2;

We should add a data type here IMAGE in enum VarType

@pzelazko-intel
Copy link
Contributor

What is the meaning of kAnyLayout?

@shanyi15
Copy link
Collaborator

您好,此issue在近一个月内暂无更新,我们将于今天内关闭。若在关闭后您仍需跟进提问,可重新开启此问题,我们将在24小时内回复您。因关闭带来的不便我们深表歉意,请您谅解~感谢您对PaddlePaddle的支持!
Hello, this issue has not been updated in the past month. We will close it today for the sake of other user‘s experience. If you still need to follow up on this question after closing, please feel free to reopen it. In that case, we will get back to you within 24 hours. We apologize for the inconvenience caused by the closure and thank you so much for your support of PaddlePaddle Group!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants