Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime Operator and Variable should take OpDesc and VarDesc as private data members #9069

Closed
QiJune opened this issue Mar 14, 2018 · 1 comment

Comments

@QiJune
Copy link
Member

QiJune commented Mar 14, 2018

Actually, we construct OpDesc and VarDesc at CompileTime, and then create Operator and Variable at CompileTime.

Operator has four data members:

std::string type_;
// NOTE: in case of OpGrad, inputs_ contains:
// I (Inputs)
// O (Outputs)
// OG (Output Gradients)
VariableNameMap inputs_;
// NOTE: in case of OpGrad, outputs_ contains
// IG (Inputs Gradients)
VariableNameMap outputs_;
AttributeMap attrs_;

These four data members are equivalent with OpDesc.

But in Variable, we do not have a VarDesc data member.

I am trying to implement re-computation policy to make further memory optimization. The re-computation policy will delete the variable in forward pass, and re-compute them in backward pass.

But If I erase the variable in current scope in forward pass, I can not compute them in backward pass. Because the variable is not exits. And the var type information in VarDesc is also lost.

A solution can be delete the variable first, and make memory released. And then create the variable again, and we need to call GetMutable method to set var type for this variable. It acquires VarDesc in a Runtime variable.

We should take OpDesc and VarDesc as a data member of Operator and Variable.

@shanyi15
Copy link
Collaborator

您好,此issue在近一个月内暂无更新,我们将于今天内关闭。若在关闭后您仍需跟进提问,可重新开启此问题,我们将在24小时内回复您。因关闭带来的不便我们深表歉意,请您谅解~感谢您对PaddlePaddle的支持!
Hello, this issue has not been updated in the past month. We will close it today for the sake of other user‘s experience. If you still need to follow up on this question after closing, please feel free to reopen it. In that case, we will get back to you within 24 hours. We apologize for the inconvenience caused by the closure and thank you so much for your support of PaddlePaddle Group!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants