Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do NOT expose temporary concepts like main_program and startup_program #9421

Closed
wangkuiyi opened this issue Mar 27, 2018 · 1 comment
Closed
Labels
User 用于标记用户问题

Comments

@wangkuiyi
Copy link
Collaborator

Currently, in our official examples, like the following on

def train_loop(main_program):

we exposed main program and startup program, which are concepts that shouldn't been there -- the only reason that we have them is because we didn't complete the implementation of the Fluid design.

Once we release a version in the current status, we are telling users that "you are recommended to create two kinds of programs explicitly" -- this is WRONG!

@wangkuiyi wangkuiyi added the User 用于标记用户问题 label Mar 27, 2018
@wangkuiyi
Copy link
Collaborator Author

We should follow the design principle as explained in #7464

@wangkuiyi wangkuiyi added this to TODO in Complete Fluid Mar 27, 2018
Complete Fluid automation moved this from TODO to Done Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User 用于标记用户问题
Projects
Development

No branches or pull requests

2 participants