Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge go/autoscaler into go/controller. #487

Closed
helinwang opened this issue Nov 10, 2017 · 4 comments
Closed

Merge go/autoscaler into go/controller. #487

helinwang opened this issue Nov 10, 2017 · 4 comments
Assignees

Comments

@helinwang
Copy link
Collaborator

helinwang commented Nov 10, 2017

The reason for separating them into two packages are:

go/controller contains the details about k8s cluster management system, in the future we could have other cluster management systems, and we can add it without changing the go/autoscaler package.

But currently we probably don't need to separate them because:

  1. Currently we don't need to support cluster management system other than k8s
  2. The go/autoscaler package are supposed to not depend on go/controller package, since it's higher level policy, and go/controller is just a cluster management system detail. But we did not do a good job, and go/autoscaler already depends on k8s detail (the resource definition are from k8s).
@typhoonzero
Copy link
Collaborator

So are we going to separate these two parts later?

@gongweibao
Copy link
Collaborator

How long does the later mean?^_^

@helinwang
Copy link
Collaborator Author

helinwang commented Nov 13, 2017

@typhoonzero I think not planned, since we don't have any plan for supporting autoscaling on anything other than k8s.

@typhoonzero
Copy link
Collaborator

Agree, Indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants