Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 paddlespeech 提交代码须知 #2325

Open
yt605155624 opened this issue Aug 30, 2022 Discussed in #1326 · 1 comment
Open

💡 paddlespeech 提交代码须知 #2325

yt605155624 opened this issue Aug 30, 2022 Discussed in #1326 · 1 comment
Assignees
Labels

Comments

@yt605155624
Copy link
Collaborator

yt605155624 commented Aug 30, 2022

Discussed in #1326

Originally posted by yt605155624 January 12, 2022

  1. 写完代码之后可以用我们的 pre-commit 检查一下代码格式,注意只改自己修改的代码的格式即可,其他的代码有可能也被改了格式,不要 add 就好
pip install pre-commit
pre-commit run --file 你修改的代码
  1. 提交 commit 中增加必要信息跳过不必要的 CI
  • 提交 asr 相关代码
git commit -m "xxxxxx, test=asr"
  • 提交 tts 相关代码
git commit -m "xxxxxx, test=tts"
  • 仅修改文档
git commit -m "xxxxxx, test=doc"

注意:

  1. 虽然跳过了 CI,但是还要先排队排到才能跳过,所以非自己方向看到 pending 不要着急 🤣
  2. git commit --amend 的时候才加 test=xxx 可能不太有效
  3. 一个 pr 多次提交 commit 注意每次都要加 test=xxx,因为每个 commit 都会触发 CI
  4. 删除 python 环境中已经安装好的的 paddlespeech,否则可能会影响 import paddlespeech 的顺序
@yt605155624 yt605155624 self-assigned this Aug 30, 2022
@yt605155624 yt605155624 changed the title paddlespeech 提交代码须知 💡 paddlespeech 提交代码须知 Sep 30, 2022
@yt605155624 yt605155624 changed the title 💡 paddlespeech 提交代码须知 ❗ paddlespeech 提交代码须知 Sep 30, 2022
@yt605155624 yt605155624 changed the title ❗ paddlespeech 提交代码须知 💡 paddlespeech 提交代码须知 Sep 30, 2022
@yt605155624 yt605155624 pinned this issue Nov 1, 2022
@stale stale bot added the Stale label Nov 22, 2022
@yt605155624 yt605155624 removed the Stale label Dec 5, 2022
@PaddlePaddle PaddlePaddle deleted a comment from stale bot Dec 22, 2022
@yt605155624 yt605155624 unpinned this issue Mar 2, 2023
@xyj44
Copy link

xyj44 commented May 26, 2023

你好,实在不知道代码运行报错发在哪,在文件夹里明明有该文件的情况下报错:FileNotFoundError: [Errno 2] No such file or directory: 'zhusheng\phone_id_map.txt',麻烦大佬帮忙看看

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants