Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud pre-commit. #204

Merged
merged 13 commits into from
Jul 11, 2017
Merged

Conversation

gongweibao
Copy link
Collaborator

@gongweibao gongweibao commented Jul 7, 2017

@gongweibao gongweibao changed the title Don't merge!Just test! Add cloud pre-commit. Jul 7, 2017
typhoonzero
typhoonzero previously approved these changes Jul 11, 2017
Copy link
Collaborator

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++ except one comment.

@@ -0,0 +1,20 @@
#!/bin/bash
function abort(){
echo "Your change doesn't follow PaddlePaddle's code style." 1>&2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PaddlePaddle => PaddleCloud

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongweibao gongweibao merged commit b00a1f6 into PaddlePaddle:develop Jul 11, 2017
@gongweibao gongweibao deleted the goprecommit branch August 21, 2017 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants