Split backend and paddlejob abstraction #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongweibao
reviewed
Sep 20, 2017
There was a problem hiding this comment.
https://github.com/kubernetes/minikube
我们需要一个单测系统，特别是多个后端的情况下。
| import utils | ||
| import volume | ||
|
|
||
| # FIXME(typhoonzero): need a base class to define the interfaces? |
There was a problem hiding this comment.
如果是想抽象多个后端的接口，Interface层还是需要的。
There was a problem hiding this comment.
所以目前是FIXME，后续增加即可。目前没必要嵌套那么多层。
| from kubernetes import client, config | ||
| from kubernetes.client.rest import ApiException | ||
| # FIXME(typhoonzero): still need to import settings | ||
| from django.conf import settings |
There was a problem hiding this comment.
所以加了FIXME，目前只能把配置都放一个settings里，分成多个配置文件，会让部署很麻烦。
另外即使要加单测，from django.conf import settings也是有方法可以使用的。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #373
After this PR we can put more backends to it to support more clusters like kubernetes.