-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #139 commit protobuf lite and a model for test #140
Conversation
在paddle-mobile repo中,我们尽量只维护我们自己的代码+必要的脚本。所以有以下几个建议:
|
源代码中应该不包含编译后生成的文件的。 |
第三方代码(protobuf)应该是在编译时clone下来,或者其他方式动态获取?而不是存在paddle-mobile的代码库里? |
关于 protobuf 这个问题, protobuf 是需要编译器clone 下来的吗? 然后根据clone 下来的protoc 生成 framework.pb.h ? |
这个二进制文件只是前期使用,为了稳定运行而用。后面会删除重新实现。 @Xreki @panyx0718 |
好的。将来删掉重新实现可能要注意清理git的历史,可能会导致git代码库比较大。 |
我个人还是觉得直接将protobuf-lite的头文件和库加入到repo里面不妥,git历史不好清理。对于protobuf-lite,我有3种方案,大家可以看下如何:
这3种方式,都不会对paddle-mobile造成巨大的改动历史。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
尽量使用头文件方式,临时加入,后续删除。后面可以对his整个目录删除。操作上要注意一下。
merged + todo label |
Should use ExternalProject or git submodule for protobuf-lite. It make no sense to directly add it into our repo. |
fix #139 commit protobuf lite and a model for test