Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils(GetTrayIcon): refactor with frontend API function #571

Merged
merged 1 commit into from Jul 29, 2020

Conversation

Palakis
Copy link
Collaborator

@Palakis Palakis commented Jul 28, 2020

Description

Fixes a crash happening in Utils::GetTrayIcon by refactoring it to remove the old Qt findChildren hack and using obs_frontend_get_system_tray instead.

Motivation and Context

Fixes #569

How Has This Been Tested?

Tested on Windows 10 2004 with t2t2's obs-tablet-remote and tray notifications enabled.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Palakis Palakis added the bug label Jul 28, 2020
@Palakis Palakis added this to the 4.9 milestone Jul 28, 2020
@Palakis Palakis self-assigned this Jul 28, 2020
@Palakis Palakis marked this pull request as ready for review July 29, 2020 12:08
@Palakis Palakis merged commit 8285805 into 4.x-current Jul 29, 2020
@tt2468 tt2468 deleted the bugfix/569-tray-icon-crash branch October 4, 2020 21:22
@steven3363
Copy link

Appears that in Linux the bug persists.
Tell me what I need to do to give you more information
Running in debug mode (OBS) it complains that the thread is duplicated.
With Notifications off it seems to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OBS Crash while changing scenes from websocket (TouchPortal/LiorianBoard)
2 participants