-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding constants for the error messages that are passed as direct values #1035
Comments
Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues. |
Hi @noman2002 @palisadoes requires review on this issue.If approved I would like to work on this. |
There are other files also with same issue , I would also like to work on this issue . |
This is a great suggestion, this would give a more consistent approach to testing as previously it felt inconsistent while writing tests for catching errors with hardcoded -strings. |
@Manoramsharma is this issue only on specific files or whole project. if its on specific file please mention the file name. |
@Manoramsharma This should be done for the whole project so reduce the PR workload. |
Create child issues for each directory, and let others work too. It will be easier to track. |
should I create the children issue? |
I may help you with this task. Either you create child issues, or I may help you with that. |
@aashimawadhwa Please proceed |
I could help with children issues also |
No this will be done for the complete project. |
Actually there are constant values that are already defined for the different values of error message/code/param that are then further used by importing the src/constants folder, in the particular file but there are still some errors for which we are using direct values of message/param/code instead of already assigning the constants then using the same.
For instance,
Describe the solution you'd like
As the solution to this given problem it is more likely to create constants named
The text was updated successfully, but these errors were encountered: