-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Typescript Rules lint warnings #1201
Comments
We can merge a contributor's pull request if they are able to resolve at least 10 warnings, but we won't mark this issue as resolved until all warnings have been fixed. This allows for the creation of pull requests by many users, which we will then merge one at a time. While the remedy is minor, it is possible that two persons worked on the same warning. In that case, whoever solves it first will have their modifications merged. |
Hey @tasneemkoushar |
@ujwalkumar1995 I have assigned this issue to you, please go ahead. |
Heyy |
I’d like to get assigned to this issue. |
Could you please assign this issue to me. |
@SiddheshKukade I'm reassigning. We need to get this resolved. |
We also need to make checks fail on these warnings |
@palisadoes Sure sir, Will enable that feature also. |
@palisadoes Sir, no problem, my exams just finished today at 2 pm. I will get started on the other assigned issues. |
Hey @anshgoyalevil @palisadoes, there are many lint warnings and errors related to this. I have been working on adding some lint rules and am already on some progress in resolving these from files. I didn't check before that there was an issue already open for it. In case you haven't started working on it, will it be fine if I make a PR for this separately? |
@KrutikaBhatt Yes sure. Go ahead. There are so many warnings and errors after enabling these rules. Your PR will be of great help. |
Unassigning due to inactivity and no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue. |
@palisadoes Sir. Could you please assign me this issue 🌚 |
Sure. Welcome back. |
@palisadoes Uh oh! Couldn't find talawa-api project in my local machine. Un-assigning! |
This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Hey @palisadoes @tasneemkoushar can you please assign this issue to me? Thanks. |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Hey @palisadoes @tasneemkoushar can you please assign this issue to me? Thanks a lot |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
There is an open PR #1412 for this issue. |
@jaas666 Hey I have no idea regarding that. Maybe the one who created this issue is not active on this. |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Describe the bug
Currently, there are too many Typescript Rules ESLint warnings in the develop branch.
Most of them are:-
"@typescript-eslint/ban-ts-comment",
"@typescript-eslint/no-explicit-any",
"@typescript-eslint/no-inferrable-types",
"@typescript-eslint/no-non-null-asserted-optional-chain",
"@typescript-eslint/no-non-null-assertion",
"@typescript-eslint/no-var-requires",
To Reproduce
Steps to reproduce the behavior:
Clone the talawa-api repository.
Install the project dependencies. (npm i)
In .eslintrc.json, change Typescript Rule, from line 49 to 54, from "off" to "warn", just like this:-
Run npm run lint:check
Expected behavior
Lint should report 0 Warnings and 0 Errors
Actual behavior
Lint now reports too many warnings.
Additional details
Multiple contributors can work together as there are too many warnings.
The text was updated successfully, but these errors were encountered: