Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typescript Rules lint warnings #1201

Closed
tasneemkoushar opened this issue Mar 19, 2023 · 35 comments · Fixed by #1412
Closed

Fix Typescript Rules lint warnings #1201

tasneemkoushar opened this issue Mar 19, 2023 · 35 comments · Fixed by #1412
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers no-issue-activity No issue activity

Comments

@tasneemkoushar
Copy link
Contributor

Describe the bug
Currently, there are too many Typescript Rules ESLint warnings in the develop branch.

Most of them are:-
"@typescript-eslint/ban-ts-comment",
"@typescript-eslint/no-explicit-any",
"@typescript-eslint/no-inferrable-types",
"@typescript-eslint/no-non-null-asserted-optional-chain",
"@typescript-eslint/no-non-null-assertion",
"@typescript-eslint/no-var-requires",

To Reproduce
Steps to reproduce the behavior:

  1. Clone the talawa-api repository.

  2. Install the project dependencies. (npm i)

  3. In .eslintrc.json, change Typescript Rule, from line 49 to 54, from "off" to "warn", just like this:-
    pic2

  4. Run npm run lint:check

Expected behavior
Lint should report 0 Warnings and 0 Errors

Actual behavior
Lint now reports too many warnings.

Additional details
Multiple contributors can work together as there are too many warnings.

@tasneemkoushar tasneemkoushar added bug Something isn't working good first issue Good for newcomers labels Mar 19, 2023
@github-actions github-actions bot added dependencies Pull requests that update a dependency file unapproved Unapproved for Pull Request labels Mar 19, 2023
@tasneemkoushar
Copy link
Contributor Author

We can merge a contributor's pull request if they are able to resolve at least 10 warnings, but we won't mark this issue as resolved until all warnings have been fixed. This allows for the creation of pull requests by many users, which we will then merge one at a time. While the remedy is minor, it is possible that two persons worked on the same warning. In that case, whoever solves it first will have their modifications merged.

@ujwalkumar1995
Copy link

Hey @tasneemkoushar
Could you please assign me this issue?
I will try to resolve as much of the issues as I can.

@tasneemkoushar
Copy link
Contributor Author

Hey @tasneemkoushar Could you please assign me this issue? I will try to resolve as much of the issues as I can.

@ujwalkumar1995 I have assigned this issue to you, please go ahead.

@nishtha981
Copy link

Heyy
Can I be assigned this issue?

@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Mar 23, 2023
@nishtha981 nishtha981 removed their assignment Apr 1, 2023
@SiddheshKukade
Copy link
Member

I’d like to get assigned to this issue.

@SiddheshKukade
Copy link
Member

Status: I currently have an exam going for this week. I'll get started on this in a few days

Exam timetable floor reference

Screenshot_2023-04-01-14-00-23-920_com.google.android.apps.docs.jpg

@anshgoyalevil
Copy link
Contributor

@palisadoes @tasneemkoushar

Could you please assign this issue to me.
I can resolve at least 1500+ warnings.

@palisadoes
Copy link
Contributor

@SiddheshKukade I'm reassigning. We need to get this resolved.

@palisadoes
Copy link
Contributor

We also need to make checks fail on these warnings

@anshgoyalevil
Copy link
Contributor

@palisadoes Sure sir, Will enable that feature also.

@SiddheshKukade
Copy link
Member

SiddheshKukade commented Apr 11, 2023

@SiddheshKukade I'm reassigning. We need to get this resolved.

@palisadoes Sir, no problem, my exams just finished today at 2 pm. I will get started on the other assigned issues.

@KrutikaBhatt
Copy link
Contributor

Hey @anshgoyalevil @palisadoes, there are many lint warnings and errors related to this. I have been working on adding some lint rules and am already on some progress in resolving these from files. I didn't check before that there was an issue already open for it. In case you haven't started working on it, will it be fine if I make a PR for this separately?

@anshgoyalevil
Copy link
Contributor

@KrutikaBhatt Yes sure. Go ahead.

There are so many warnings and errors after enabling these rules. Your PR will be of great help.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jun 2, 2023
@palisadoes
Copy link
Contributor

Unassigning due to inactivity and no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@anshgoyalevil
Copy link
Contributor

@palisadoes Sir. Could you please assign me this issue 🌚

@palisadoes
Copy link
Contributor

Sure. Welcome back.

@palisadoes palisadoes removed the no-issue-activity No issue activity label Jun 4, 2023
@anshgoyalevil
Copy link
Contributor

@palisadoes Uh oh! Couldn't find talawa-api project in my local machine. Un-assigning!

@anshgoyalevil anshgoyalevil removed their assignment Jun 4, 2023
@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jun 15, 2023
@git-init-priyanshu
Copy link
Member

git-init-priyanshu commented Sep 17, 2023

Hey @palisadoes @tasneemkoushar can you please assign this issue to me? Thanks.

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Oct 1, 2023
@parthiv360
Copy link
Contributor

Hey @palisadoes @tasneemkoushar can you please assign this issue to me? Thanks a lot

@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Oct 29, 2023
@jaas666
Copy link

jaas666 commented Oct 29, 2023

There is an open PR #1412 for this issue.
Was it ever reviewed?

@parthiv360
Copy link
Contributor

@jaas666 Hey I have no idea regarding that. Maybe the one who created this issue is not active on this.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Oct 30, 2023
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers no-issue-activity No issue activity
Projects
None yet