Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for src/resolvers/Query/getDonationByOrgIdConnection.ts #1206

Closed
KrutikaBhatt opened this issue Mar 20, 2023 · 3 comments
Closed

Tests for src/resolvers/Query/getDonationByOrgIdConnection.ts #1206

KrutikaBhatt opened this issue Mar 20, 2023 · 3 comments
Labels
parent Parent issue test Testing application unapproved Unapproved for Pull Request

Comments

@KrutikaBhatt
Copy link
Contributor

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage covering all the file

  • Tests need to be written for file src/resolvers/Query/getDonationByOrgIdConnection.ts.
  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all methods, classes, and/or functions in the refactored file will need to be tested.
  • These tests must be placed in a single file with the name tests/resolvers/Query/src/resolvers/Query/getDonationByOrgIdConnection.ts You may need to create the appropriate directory structure to do this.

Screenshot:
Please find the screenshot of the codecov report generated for the application.
image
IMPORTANT:
Please refer to the parent issue on how to implement these tests correctly: #490

@github-actions github-actions bot added parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Mar 20, 2023
@anshgoyalevil
Copy link
Contributor

anshgoyalevil commented Mar 20, 2023

@KrutikaBhatt

There is a separate idea for GSoC'23 regarding the donations system as a plugin.
This file would be therefore modified.

@KrutikaBhatt
Copy link
Contributor Author

Yes yes, got it! Should I close this issue? It can be reopened once the work is completed later

@anshgoyalevil
Copy link
Contributor

@KrutikaBhatt

Yes. You may close it as of now.

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parent Parent issue test Testing application unapproved Unapproved for Pull Request
Projects
None yet
Development

No branches or pull requests

3 participants