Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Adding the generatedGraphQLTypes.ts to gitignore #1338

Closed
SiddheshKukade opened this issue May 20, 2023 · 9 comments
Closed

Bug Report: Adding the generatedGraphQLTypes.ts to gitignore #1338

SiddheshKukade opened this issue May 20, 2023 · 9 comments
Assignees
Labels
bug Something isn't working no-issue-activity No issue activity unapproved Unapproved for Pull Request

Comments

@SiddheshKukade
Copy link
Member

Describe the bug
I'm getting this generatedGraphQLTypes.ts file generated automatically after compiling the project with npm run dev should we add it to gitignore

To Reproduce
Steps to reproduce the behavior:

  1. Clone repo
  2. Do npm run dev
  3. File generatedGraphQLTypes.ts gets generated and it's untracked on git.

Expected behavior
It can be ignored to git if not important.

Actual behavior
The files getting untracked unnecessarily.
Screenshots
image
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@SiddheshKukade SiddheshKukade added the bug Something isn't working label May 20, 2023
@github-actions github-actions bot added the unapproved Unapproved for Pull Request label May 20, 2023
@SiddheshKukade
Copy link
Member Author

/cc @kb-0311 @tasneemkoushar @aashimawadhwa feedback would be appreciated.

@xoldd
Copy link
Contributor

xoldd commented May 21, 2023

@SiddheshKukade I guess you can get rid of it but you have to make sure that it's generated during all workflows and processes where typescript is concerned. One example is, it should be automatically generated each time someone clones the repo and installs dependencies on their local systems. I doubt there are many places where that's needed tho.

@SiddheshKukade
Copy link
Member Author

So @xoldyckk would it be better to merge this file in the repo can it solve the issues ? What do you think?

@xoldd
Copy link
Contributor

xoldd commented May 21, 2023

So @xoldyckk would it be better to merge this file in the repo can it solve the issues ? What do you think?

I didn't understand what you meant by that.

@palisadoes
Copy link
Contributor

@SiddheshKukade What is the status of this?

@SiddheshKukade
Copy link
Member Author

@palisadoes sir, I'm actually having practical exams untill 3rd june and I've requested to take break for some days from my mentor tasneem mam.
I'll get started to work on this in a few days.

@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jun 15, 2023
@palisadoes
Copy link
Contributor

What's the status on this?

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jun 28, 2023
@github-actions
Copy link

github-actions bot commented Jul 9, 2023

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity No issue activity unapproved Unapproved for Pull Request
Projects
None yet
Development

No branches or pull requests

3 participants