Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some files have lines that are not covered in testing #1420

Closed
nitishkumar333 opened this issue Nov 4, 2023 · 4 comments
Closed

Some files have lines that are not covered in testing #1420

nitishkumar333 opened this issue Nov 4, 2023 · 4 comments
Assignees
Labels
bug Something isn't working no-issue-activity No issue activity

Comments

@nitishkumar333
Copy link
Contributor

Describe the bug
There are several files with lines that are not covered in testing which is reducing the code coverage and also some indirect changes are causing PR's codecov report to fail.

Files which I will be covering in this issue

  1. src\resolvers\middleware\currentUserExists.ts
  2. src\resolvers\Mutation\createMember.ts
  3. src\resolvers\Mutation\createPost.ts
  4. src\resolvers\Mutation\updatePost.ts
  5. src\resolvers\Query\helperFunctions\getWhere.ts
  6. src\utilities\encodedImageStorage\uploadEncodedImage.ts
  7. src\utilities\encodedVideoStorage\uploadEncodedVideo.ts

Expected behavior
All lines in these files should be covered.

Actual behavior
Some lines are not covered in testing

@nitishkumar333 nitishkumar333 added the bug Something isn't working label Nov 4, 2023
@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Nov 4, 2023
@palisadoes
Copy link
Contributor

Do you want to work on this to get the code coverage above our standard 95%?

@nitishkumar333
Copy link
Contributor Author

@palisadoes Yes, I will be writing tests that will cover the missing lines and thus will eventually increase the code coverage.

please assign it to me

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Nov 16, 2023
@palisadoes
Copy link
Contributor

Closing due to inactivity. We now have separate issues for these files

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity No issue activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants