Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an identifier Field to the User Collection #1554

Open
palisadoes opened this issue Dec 24, 2023 · 31 comments
Open

Create an identifier Field to the User Collection #1554

palisadoes opened this issue Dec 24, 2023 · 31 comments
Labels

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 24, 2023

Is your feature request related to a problem? Please describe.

The User collection currently has a _id field. This is an internal unique identifier. Unfortunately it is not easily memorable. We need a memorable ID that an Talawa Administrator or User can use to reference themselves or other users.

It's to help provide a means for searching for someone by a member ID that you would find on a membership card

Describe the solution you'd like

  1. We need to add an identifier field to the User collection
  2. This field must be:
    1. memorable
    2. numeric
    3. auto-incrementing
    4. sequential
    5. immutable after applying
    6. mandatory
  3. Automatically applied when the User is created in the related mutation
  4. Valid tests for this must be created as part of the resolution of this issue
  5. You will need to update the sample data users.json file accordingly. The data importation must succeed and the ability to navigate through the client apps must not be affected.

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • See above

Additional context

  • N/A

Potential internship candidates

@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Dec 24, 2023
@adi790uu
Copy link
Contributor

Would like to work on this @palisadoes @noman2002

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved for Pull Request label Dec 25, 2023
Copy link

github-actions bot commented Jan 5, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 5, 2024
@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity

@shankeleven
Copy link

@palisadoes please assign this to me, would love to work

@TheLazron
Copy link

@palisadoes can I be assigned this issue?

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jan 6, 2024
@shankeleven
Copy link

Apologies but i am new to this repository , so i would ask for some guidance

i propose a solution to this problem could be something similar to a username in other social media websites, which goes as:
we assign each user a random username(or identifier) based on the initials of his name and some random number
and we offer the user the option to create their own username if they want to, and those who choose not to create one for themselves would continue with the one generated automatically.
i am keeping this optional because the aim of our organisation is to cater to even those people who are not that well versed with the current technology so why create an additional hurdle for them.

please tell me if you have any opinions or some suggestions regarding this,

@palisadoes
Copy link
Contributor Author

We want what is described in the issue.

@shankeleven
Copy link

thanks for answering .
okay , i would do exactly that,
but what i am curious about is if the point of the identifier is to be just memorable as otherwise we wouldn't need it as we already have _id as the unique identifier
wouldn't it be more useful to have a combination of initials and numbers rather than just a numeric value as it would be easier for you to remember Palis1020 than to remember 45981020

@palisadoes
Copy link
Contributor Author

It's to help provide a means for searching for someone by a member ID that you would find on a membership card

@nakul30
Copy link

nakul30 commented Jan 13, 2024

It's to help provide a means for searching for someone by a member ID that you would find on a membership card

Hello Palisadoes,
Can you assign the issue to me.

@Cioppolo14
Copy link
Contributor

@nakul30 If the issue has already been assigned, please don't ask to be assigned. We want everyone to get a chance.

@nakul30
Copy link

nakul30 commented Jan 14, 2024

@nakul30 If the issue has already been assigned, please don't ask to be assigned. We want everyone to get a chance.

Please assign the issue to me if not ressolved by the person whom it is assigned as i have just begun with open source

@shankeleven
Copy link

@palisadoes sir i am almost done with the issue , was just curious about one thing
shall i begin the count for the identifier field from 0 itself or some number like 1000 or 10000 or even 100000 for that matter in order for most of the identifiers to be around the same digits long?

@palisadoes
Copy link
Contributor Author

Start with 0

Copy link

github-actions bot commented Feb 2, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 2, 2024
@Cioppolo14
Copy link
Contributor

@shankeleven Is a PR coming soon?

@shankeleven
Copy link

yes ma'am
hopefully by tonight
otherwise tomorrow

@palisadoes
Copy link
Contributor Author

Please note:

image

@shankeleven
Copy link

@palisadoes sir please review the pull request #1811

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 23, 2024
@Cioppolo14 Cioppolo14 removed the no-issue-activity No issue activity label Feb 23, 2024
Copy link

github-actions bot commented Mar 5, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 5, 2024
@palisadoes
Copy link
Contributor Author

Unassigning as the PR was abandoned

@github-actions github-actions bot removed the no-issue-activity No issue activity label Apr 1, 2024
@shankeleven
Copy link

@palisadoes it isn't abandoned, it was just that the linting errors were somewhat confusing because they were arriving from files i did not edit, currently my semester exams are going on , so i had thought of correcting this once they end

@palisadoes
Copy link
Contributor Author

I've reassigned. I was reviewing long standing PRs that had no recent activity and closed yours. Sorry. We should have given a 24 hour warning. We'll remember next time.

@pranshugupta54
Copy link
Member

Do we really need a public member ID? Is it really helpful?

  • If an organization has lots of users, the member ID might become very long (like 12138 if it starts from 0), making it hard to remember.
  • Starting from 0 could make it worse, causing IDs with different lengths, which could confuse users when they talk about their IDs. Usually, IDs have the same number of digits (like credit card numbers or phone numbers).
  • It's not a good idea to use member IDs for searching. It's better to use email addresses because people can remember their email addresses easier than their member IDs.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 13, 2024
@Cioppolo14
Copy link
Contributor

Unassigning due to no pr or activity.

@Cioppolo14 Cioppolo14 removed the no-issue-activity No issue activity label Apr 15, 2024
@varshith257
Copy link
Member

@palisadoes @Cioppolo14 I would like to work on this issue.

@Cioppolo14
Copy link
Contributor

@varshith257 Somehow I missed that a PR was open for this issue, I'm going to reassign @shankeleven, but if I don't get an update from them soon, you will get this next.

@palisadoes
Copy link
Contributor Author

Unassigning due to abandoned PR

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants