Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely Lint the Codebase with ESlint #252

Closed
palisadoes opened this issue May 22, 2021 · 3 comments
Closed

Completely Lint the Codebase with ESlint #252

palisadoes opened this issue May 22, 2021 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers unapproved Unapproved for Pull Request

Comments

@palisadoes
Copy link
Contributor

Describe the bug
The code base needs to be completely linted to reduce linting errors and future merge conflicts

To Reproduce
Steps to reproduce the behavior:

  1. When pull requests are submitted they fail due to linting errors in our GitHub actions.
  2. A sample screen shot of the failed PRs is attached.
  3. Sample of the GitHub actions ESlint output
    image

Expected behavior
Our GitHub pull request action needs to be able to pass without errors. Everything green.

Actual behavior
We see these errors when the es-lint action is run. There are multiple linting issues with the code base when running the ESlint GitHub action.

Run stefanoeb/eslint-action@1.0.2
/usr/bin/docker run --name a33c1fb86ea4f7d554705bd87791b2c31389c_390c0d --label 8a33c1 --workdir /github/workspace --rm -e INPUT_FILES -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_RETENTION_DAYS -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e GITHUB_ACTION_REPOSITORY -e GITHUB_ACTION_REF -e GITHUB_PATH -e GITHUB_ENV -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/talawa-api/talawa-api":"/github/workspace" 8a33c1:fb86ea4f7d554705bd87791b2c31389c  "."
## Your environment is not ready yet. Installing modules...
## Running ESLint
(node:10) Warning: .then() only accepts functions but was passed: [object Object]
(node:10) Warning: .then() only accepts functions but was passed: [object Object]
(node:10) Warning: .then() only accepts functions but was passed: [object Object]
(node:10) Warning: .then() only accepts functions but was passed: [object Object]
(node:10) Warning: .then() only accepts functions but was passed: [object Object]
(node:10) Warning: .then() only accepts functions but was passed: [object Object]
(node:10) Warning: .then() only accepts functions but was passed: [object Object]
(node:10) Warning: .then() only accepts functions but was passed: [object Object]
(node:10) Warning: .then() only accepts functions but was passed: [object Object]
(node:10) Warning: .then() only accepts functions but was passed: [object Object]
(node:10) Warning: .then() only accepts functions but was passed: [object Object]
(node:10) Warning: .then() only accepts functions but was passed: [object Object]
(node:10) Warning: .then() only accepts functions but was passed: [object Object]
(node:10) Warning: .then() only accepts functions but was passed: [object Object]

Screenshots
See above
Additional details

@palisadoes palisadoes added the good first issue Good for newcomers label May 22, 2021
@github-actions github-actions bot added bug Something isn't working unapproved Unapproved for Pull Request labels May 22, 2021
@uzaxirr
Copy link
Contributor

uzaxirr commented Aug 2, 2021

Hey there!!
Would love to take up this issue can I use this action

@palisadoes
Copy link
Contributor Author

@uzair-ali10 This may have been resolved. We are using linters in the GitHub workflow

@uzaxirr
Copy link
Contributor

uzaxirr commented Aug 3, 2021

@palisadoes
If it has been resolved i guess you can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers unapproved Unapproved for Pull Request
Projects
None yet
Development

No branches or pull requests

2 participants