Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MVVM to Separate Business Logic #266

Closed
palisadoes opened this issue May 24, 2021 · 3 comments
Closed

Use MVVM to Separate Business Logic #266

palisadoes opened this issue May 24, 2021 · 3 comments
Labels
no-issue-activity No issue activity unapproved Unapproved for Pull Request

Comments

@palisadoes
Copy link
Contributor

palisadoes commented May 24, 2021

Is your feature request related to a problem? Please describe.

  1. We need to separating out db methods, and business logic from mutations, handlers and controllers
  2. All of the business logic let it be controllers, core-service logic, DB calls logic are currently all in one function in resolvers

Describe the solution you'd like

  1. Controllers / Resolvers currently this is called as mutation resolvers in talawa-API can be reused folder, which will do marshaling, unmarshalling, schema validation of data
  2. Services folder, which will mainly deal will business logic
  3. Repositories folder, which will deal with DB calls
  4. Having a core folder that will keep track of all the helper, constants, utils, lib files.

Describe alternatives you've considered

N/A

Approach to be followed (optional)

Discuss in the comments below

Additional context

Parent issue #259

@github-actions github-actions bot added the unapproved Unapproved for Pull Request label May 24, 2021
@github-actions
Copy link

This issue did not get any activity in the past 60 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 30, 2021
@SiddheshKukade
Copy link
Member

@palisadoes Should we close this as the parent issue is also closed ?

@palisadoes
Copy link
Contributor Author

Closed. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-issue-activity No issue activity unapproved Unapproved for Pull Request
Projects
None yet
Development

No branches or pull requests

2 participants