Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolvers: Create tests for createGroupChat.js #532

Closed
palisadoes opened this issue Feb 24, 2022 · 1 comment
Closed

Resolvers: Create tests for createGroupChat.js #532

palisadoes opened this issue Feb 24, 2022 · 1 comment
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/resolvers/group_chat_mutations/createGroupChat.js

  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
    single file with the name tests/resolvers/group_chat_mutations/createGroupChat.spec.js. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
@palisadoes palisadoes added the bug Something isn't working label Feb 24, 2022
@github-actions github-actions bot added parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Feb 24, 2022
@palisadoes palisadoes added good first issue Good for newcomers points 02 and removed bug Something isn't working parent Parent issue labels Mar 2, 2022
@saga0p
Copy link
Contributor

saga0p commented Apr 13, 2022

can you assign this to me. I've already made the PRs for the existing issues which are assigned to me and I've also contacted the assigned reviewers on slack to review my PR. I'm available to work on this issue now

@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants