Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolvers: Create tests for updateOrganization.js #552

Closed
palisadoes opened this issue Feb 24, 2022 · 9 comments · Fixed by #667
Closed

Resolvers: Create tests for updateOrganization.js #552

palisadoes opened this issue Feb 24, 2022 · 9 comments · Fixed by #667
Assignees
Labels
good first issue Good for newcomers test Testing application unapproved Unapproved for Pull Request

Comments

@palisadoes
Copy link
Contributor

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/resolvers/organization_mutations/updateOrganization.js

  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
    single file with the name tests/resolvers/organization_mutations/updateOrganization.spec.js. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
@palisadoes palisadoes added the bug Something isn't working label Feb 24, 2022
@github-actions github-actions bot added parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Feb 24, 2022
@palisadoes palisadoes added good first issue Good for newcomers points 02 and removed bug Something isn't working parent Parent issue labels Mar 2, 2022
@saga0p
Copy link
Contributor

saga0p commented Apr 4, 2022

can you assign this to me

@palisadoes
Copy link
Contributor Author

You already have 3 issues assigned. Please focus on closing those.

@saga0p
Copy link
Contributor

saga0p commented Apr 4, 2022

Two issues are already approved and merged and I've made a PR for the 3rd issue too. So now I can work on a new issue

@palisadoes
Copy link
Contributor Author

Why aren't the issues closed?

@saga0p
Copy link
Contributor

saga0p commented Apr 4, 2022

can i close it by myself as the PRs are merged?

@palisadoes
Copy link
Contributor Author

There is an autoclosing feature in GitHub. It's outlined in the CONTRIBUTING.md file.

@palisadoes
Copy link
Contributor Author

Please use the templates that we provide for submitting your PRs. They are there for a reason. In this case, the issues would have been closed automatically.

@palisadoes
Copy link
Contributor Author

The time of our contributors and reviewers is valuable. I'm sure you understand. The procedures are put in place to help everyone, you included. Please follow the process in future. I'll assign the issue

@saga0p
Copy link
Contributor

saga0p commented Apr 4, 2022

yes, I understand. sorry for missing these details, I'll keep this in mind from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application unapproved Unapproved for Pull Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants