Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request #675

Closed
ebrahim354 opened this issue Apr 12, 2022 · 2 comments · Fixed by #676
Closed

Feature Request #675

ebrahim354 opened this issue Apr 12, 2022 · 2 comments · Fixed by #676
Assignees
@ebrahim354
Labels
feature request

Comments

@ebrahim354
Copy link
Contributor

Is your feature request related to a problem? Please describe.
So many hard coded values are scattered around the code that will cause problems later.

Describe the solution you'd like
a global Constants file or even folder that hold them and helps manage the code more easily.

Additional context
This was requested by the mentors on : #674
@ebrahim354
Copy link
Contributor Author

I want to work on it please.

@github-actions
Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Apr 12, 2022
@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Apr 12, 2022
@ebrahim354 ebrahim354 mentioned this issue Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebrahim354 ebrahim354

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed hardcodded error strings
2 participants
@palisadoes @ebrahim354