Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolvers: Create Tests for File.js #802

Closed
SiddheshKukade opened this issue Dec 5, 2022 · 2 comments
Closed

Resolvers: Create Tests for File.js #802

SiddheshKukade opened this issue Dec 5, 2022 · 2 comments
Labels
good first issue Good for newcomers parent Parent issue test Testing application unapproved Unapproved for Pull Request

Comments

@SiddheshKukade
Copy link
Member

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/models/File.js

  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
    single file with the name tests/models/File.sepc.js. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
@SiddheshKukade SiddheshKukade added unapproved Unapproved for Pull Request points 01 test Testing application labels Dec 5, 2022
@github-actions github-actions bot added the parent Parent issue label Dec 5, 2022
@SiddheshKukade SiddheshKukade added the good first issue Good for newcomers label Dec 5, 2022
@beingnoble03
Copy link
Member

@SiddheshKukade we have currently excluded models from coverage. So, I think we can close this issue?

@beingnoble03
Copy link
Member

@SiddheshKukade we have currently excluded models from coverage. So, I think we can close this issue?

@palisadoes Can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers parent Parent issue test Testing application unapproved Unapproved for Pull Request
Projects
None yet
Development

No branches or pull requests

3 participants