Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolvers: Create Tests for removeDirectChat.js #809

Closed
SiddheshKukade opened this issue Dec 5, 2022 · 3 comments · Fixed by #821
Closed

Resolvers: Create Tests for removeDirectChat.js #809

SiddheshKukade opened this issue Dec 5, 2022 · 3 comments · Fixed by #821
Assignees
Labels
parent Parent issue test Testing application

Comments

@SiddheshKukade
Copy link
Member

SiddheshKukade commented Dec 5, 2022

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file /src/lib/resolvers/Mutation/removeDirectChat.ts

  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
    single file with the name tests/resolvers/Mutation/removeDirectChat.sepc.js. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
@SiddheshKukade SiddheshKukade added the bug Something isn't working label Dec 5, 2022
@github-actions github-actions bot added parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Dec 5, 2022
@SiddheshKukade SiddheshKukade added points 02 and removed bug Something isn't working labels Dec 5, 2022
@beingnoble03
Copy link
Member

@SiddheshKukade I think the correct path here is /src/lib/resolvers/Mutation/removeDirectChat.ts. If so, can I work on this?
I have opened a PR for my previously assigned issue.

@beingnoble03
Copy link
Member

@SiddheshKukade can you assign me this issue?

@SiddheshKukade
Copy link
Member Author

@palisadoes Sir, Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parent Parent issue test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants