Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolvers: Create Tests for resolvers/DirectChat/index.ts #810

Closed
SiddheshKukade opened this issue Dec 5, 2022 · 6 comments · Fixed by #835
Closed

Resolvers: Create Tests for resolvers/DirectChat/index.ts #810

SiddheshKukade opened this issue Dec 5, 2022 · 6 comments · Fixed by #835
Assignees
Labels
good first issue Good for newcomers parent Parent issue test Testing application

Comments

@SiddheshKukade
Copy link
Member

SiddheshKukade commented Dec 5, 2022

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file src/lib/resolvers/DirectChat/index.ts

  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
    single file with the name src/lib/resolvers/DirectChat/index.spec.ts. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
@SiddheshKukade SiddheshKukade added good first issue Good for newcomers unapproved Unapproved for Pull Request points 02 test Testing application labels Dec 5, 2022
@github-actions github-actions bot added the parent Parent issue label Dec 5, 2022
@cAmartya
Copy link

Hey @SiddheshKukade , I want to work on this issue. Can you assign it to me?

@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Dec 17, 2022
@cAmartya
Copy link

cAmartya commented Dec 18, 2022

Hey @SiddheshKukade , I think the folder structure might have been updated, I don't think the file directChat.js according to the path lib/resolvers/direct_chat_query/directChat.js exists. The folder direct_chat_query is not present

image

Should I write tests for Query/directChats.ts in the file Query/directChats.spec.ts ?

@beingnoble03
Copy link
Member

beingnoble03 commented Dec 29, 2022

@SiddheshKukade can you please assign me this issue?

@beingnoble03
Copy link
Member

Do we need to work here for src/lib/resolvers/DirectChat/index.ts? Can you please confirm once?

@SiddheshKukade SiddheshKukade changed the title Resolvers: Create Tests for directChats.js Resolvers: Create Tests for resolvers/DirectChat/index.ts Dec 30, 2022
@SiddheshKukade
Copy link
Member Author

Do we need to work here for src/lib/resolvers/DirectChat/index.ts? Can you please confirm once?

Yes

@beingnoble03
Copy link
Member

Do we need to work here for src/lib/resolvers/DirectChat/index.ts? Can you please confirm once?

Yes

Can you please assign me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers parent Parent issue test Testing application
Projects
None yet
4 participants