Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: src/lib/resolvers/Query/postsByOrganizationConnection.ts #893

Closed
palisadoes opened this issue Jan 24, 2023 · 12 comments
Closed

Test: src/lib/resolvers/Query/postsByOrganizationConnection.ts #893

palisadoes opened this issue Jan 24, 2023 · 12 comments
Labels
good first issue Good for newcomers test Testing application unapproved Unapproved for Pull Request

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 24, 2023

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

  • Tests need to be written for file src/lib/resolvers/Query/postsByOrganizationConnection.ts
  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
    single file with the name __tests__/resolvers/Query/postsByOrganizationConnection.spec.ts. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found by visting this page. Login using your GitHub credentials.
  • Create your own codecov.io to help with testing.
  • The PR you create will show a report for the code coverage for the file you have added. You can also use that as a guide.
@palisadoes palisadoes added the bug Something isn't working label Jan 24, 2023
@github-actions github-actions bot added parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Jan 24, 2023
@palisadoes palisadoes added good first issue Good for newcomers points 01 and removed bug Something isn't working parent Parent issue labels Jan 24, 2023
@gurpreet-legend
Copy link

@noman2002 @tonythegr8 @nesiann, I would like to work on this

@noman2002
Copy link
Member

@gurpreet-legend 2 issues are already assigned to you. Please work on them and get the PR merged.

@arunavabasucom
Copy link
Contributor

can you assign it to me ??

@noman2002
Copy link
Member

Sure.

@noman2002 noman2002 removed the unapproved Unapproved for Pull Request label Jan 29, 2023
@kb-0311
Copy link
Contributor

kb-0311 commented Feb 9, 2023

@arunavabasu-03 are you still working on this issue? If not can I take up this issue instead?

@noman2002
Copy link
Member

Unassigned due to inactivity

@noman2002 noman2002 added the unapproved Unapproved for Pull Request label Feb 12, 2023
@noman2002
Copy link
Member

@kb-0311 You already have 3 across the repos. get them merged first.

@anshgoyalevil
Copy link
Contributor

@palisadoes I just checked this file, and it already have a test written for it, with 100% code coverage. This issue may be closed.

@palisadoes
Copy link
Contributor Author

It's at 24% search for postsByOrganizationConnection.ts in the link above

@anshgoyalevil
Copy link
Contributor

It's at 24% search for postsByOrganizationConnection.ts in the link above

But, I checked it locally, and it is 100%

image

@anshgoyalevil
Copy link
Contributor

I guess, it is an issue with CodeCov.

@anshgoyalevil
Copy link
Contributor

It's at 24% search for postsByOrganizationConnection.ts in the link above

But, I checked it locally, and it is 100%

image

@palisadoes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application unapproved Unapproved for Pull Request
Projects
None yet
Development

No branches or pull requests

6 participants