Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: src/lib/directives/index.ts #919

Closed
palisadoes opened this issue Jan 24, 2023 · 12 comments · Fixed by #960
Closed

Test: src/lib/directives/index.ts #919

palisadoes opened this issue Jan 24, 2023 · 12 comments · Fixed by #960
Assignees
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 24, 2023

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

  • Tests need to be written for file src/lib/directives/index.ts
  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
    single file with the name __tests__/directives/index.spec.ts. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found by visting this page. Login using your GitHub credentials.
  • Create your own codecov.io to help with testing.
  • The PR you create will show a report for the code coverage for the file you have added. You can also use that as a guide.
@palisadoes palisadoes added the bug Something isn't working label Jan 24, 2023
@github-actions github-actions bot added parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Jan 24, 2023
@palisadoes palisadoes removed bug Something isn't working parent Parent issue labels Jan 24, 2023
@Rishab49
Copy link

I want to work on this

@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Jan 27, 2023
@anshgoyalevil
Copy link
Contributor

anshgoyalevil commented Jan 29, 2023

I would like to work on this issue, as I have completed the test file for it, with 100% code coverage. Could you please assign it to me. @palisadoes

@noman2002
Copy link
Member

@anshgoyalevil It is assigned to @Rishab49 yesterday. You can work on some other issue.

@anshgoyalevil
Copy link
Contributor

@Rishab49 are you still working upon this issue?

@aviraldevv
Copy link
Contributor

@Rishab49 if you need any help for this you can refer to my PR this issue is same with minor tweak. I am attaching my PR link for reference #945 . Best Wishes!!!

@anshgoyalevil
Copy link
Contributor

@Rishab49 Are you still working on it.

@Rishab49
Copy link

No I'm not

@anshgoyalevil
Copy link
Contributor

@palisadoes Could you please assign this issue to me.

@aviraldevv
Copy link
Contributor

@anshgoyalevil could you please let me work on this issue I have done similar work earlier, currently the issue I was working on might get closed.

@palisadoes palisadoes assigned anshgoyalevil and unassigned Rishab49 Jan 31, 2023
@aviraldevv
Copy link
Contributor

Nevermind you have been assigned you can work.

@anshgoyalevil
Copy link
Contributor

@anshgoyalevil could you please let me work on this issue I have done similar work earlier, currently the issue I was working on might get closed.

Totally understand your point buddy, but, I have also worked upon the similar issue, and that one is closed as well. Hope you get any other issue to work upon. Thanks.

@aviraldevv
Copy link
Contributor

Definitely buddy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants