Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI changes #1097

Closed
ItsAdityaKSingh opened this issue Jan 3, 2022 · 8 comments
Closed

UI changes #1097

ItsAdityaKSingh opened this issue Jan 3, 2022 · 8 comments
Labels
bug Something isn't working unapproved Unapproved, needs to be triaged

Comments

@ItsAdityaKSingh
Copy link

ItsAdityaKSingh commented Jan 3, 2022

Describe the bug
The current UI for dark mode is not appealing or does not showcase the important parts of the app. The Circular loading button can be improved. On the Chats screen, the tab color has a different green than the one used all over the app. From the onboarding screen to various Page titles and content, it can be improved with typical and custom talawa colors!

To Reproduce
Steps to reproduce the behavior:

  1. Open App in Dark Mode
  2. See the onboarding screen for the first time
  3. Switch between Screens to see dull UI

Expected behavior
A clear UI theme and colors could be used, highlighting the main parts and titles with brighter shades.

Actual behavior
The UI was dull and unappealing for a user.

Screenshots

Screenshot 2022-01-03 at 3 34 26 PM

Additional details
The UIs need to be consistent with App's overall color scheme and look appealing and noticeable.

@ItsAdityaKSingh ItsAdityaKSingh added the bug Something isn't working label Jan 3, 2022
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Jan 3, 2022
@ItsAdityaKSingh
Copy link
Author

@palisadoes I would like to work on this issue and improve the UI for the better!

@palisadoes
Copy link
Contributor

@rutvik11062000 What do you think? I'd greatly prefer changes to meet your design specification.

@palisadoes
Copy link
Contributor

@ItsAdityaKSingh We have raised our code coverage percentage to 34%, so you'll need to add tests to this issue for the PRs to be approved.

@ItsAdityaKSingh
Copy link
Author

@ItsAdityaKSingh We have raised our code coverage percentage to 34%, so you'll need to add tests to this issue for the PRs to be approved.

So, basically, will I need to write tests first for the particular widgets or UI components I want to change?

@palisadoes
Copy link
Contributor

Yes

@ItsAdityaKSingh
Copy link
Author

Ok. Could you help me by guiding me in a direction to start writing tests, like from which widget or function should I start unit testing so as to be able to resolve this issue?

@palisadoes
Copy link
Contributor

palisadoes commented Jan 3, 2022

@ItsAdityaKSingh

This should give you an idea of how to proceed on widgets and other code.

  • Any code you submit must be tested.
  • If your code uses any widget, then you must ensure that the widget in question has a test too.

@ItsAdityaKSingh
Copy link
Author

@ItsAdityaKSingh

This should give you an idea of how to proceed on widgets and other code.

  • Any code you submit must be tested.
  • If your code uses any widget, then you must ensure that the widget in question has a test too.

Sure. Thanks a ton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unapproved Unapproved, needs to be triaged
Projects
None yet
Development

No branches or pull requests

3 participants