Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views: Create tests for base_view.dart #1226

Closed
palisadoes opened this issue Feb 28, 2022 · 4 comments
Closed

Views: Create tests for base_view.dart #1226

palisadoes opened this issue Feb 28, 2022 · 4 comments
Labels
good first issue Good for newcomers test Testing application unapproved Unapproved, needs to be triaged

Comments

@palisadoes
Copy link
Contributor

The Talawa code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/views/base_view.dart

  • When complete, all methods, classes and/or functions in the file will need to be tested.
  • These tests must be placed in a single file with the name test/views_test/base_view_test.dart. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
  • You can verify your own code coverage by creating an account at Codecov.io
@palisadoes palisadoes added the bug Something isn't working label Feb 28, 2022
@github-actions github-actions bot added parent The issue is generating more sub-issues test Testing application unapproved Unapproved, needs to be triaged labels Feb 28, 2022
@palisadoes palisadoes added good first issue Good for newcomers and removed bug Something isn't working parent The issue is generating more sub-issues labels Mar 2, 2022
@arunavabasucom
Copy link

Can I tackle this one !!

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Dec 7, 2022
@noman2002
Copy link
Member

noman2002 commented Jan 26, 2023

Are you working on this issue @arunavabasu-03 . If not, please unassign yourself.

@arunavabasucom
Copy link

Yup , working !!

@arunavabasucom arunavabasucom removed their assignment Jan 26, 2023
@noman2002 noman2002 added the unapproved Unapproved, needs to be triaged label Jan 29, 2023
@Ayush0Chaudhary
Copy link

It already has 100% coverage due to Other test, we can close this issue @palisadoes @noman2002 @TheHazeEffect
Screenshot from 2023-02-06 22-13-13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application unapproved Unapproved, needs to be triaged
Projects
None yet
Development

No branches or pull requests

4 participants