Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views: Create tests for app_settings_page.dart #1244

Closed
palisadoes opened this issue Feb 28, 2022 · 3 comments · Fixed by #1262
Closed

Views: Create tests for app_settings_page.dart #1244

palisadoes opened this issue Feb 28, 2022 · 3 comments · Fixed by #1262
Labels
good first issue Good for newcomers test Testing application unapproved Unapproved, needs to be triaged

Comments

@palisadoes
Copy link
Contributor

The Talawa code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/views/after_auth_screens/app_settings/app_settings_page.dart

  • When complete, all methods, classes and/or functions in the file will need to be tested.
  • These tests must be placed in a single file with the name test/views/after_auth_screens/app_settings_test/app_settings_page_test.dart. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
  • You can verify your own code coverage by creating an account at Codecov.io
@palisadoes palisadoes added the bug Something isn't working label Feb 28, 2022
@github-actions github-actions bot added parent The issue is generating more sub-issues test Testing application unapproved Unapproved, needs to be triaged labels Feb 28, 2022
@palisadoes palisadoes added points 01 good first issue Good for newcomers and removed bug Something isn't working parent The issue is generating more sub-issues labels Mar 1, 2022
@CyberWake
Copy link
Contributor

@palisadoes can you assign this to me.

@Sagar2366
Copy link
Contributor

We can definitely assign more issues to you.
@CyberWake can you please finish working on other assigned issues ?

@palisadoes
Copy link
Contributor Author

@CyberWake I mistakenly merged your PR which for this issue when you were not assigned the task. Please do not submit PRs for issues to which you are not assigned. You risk the PR being closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application unapproved Unapproved, needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants