Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code requires formatting, for readability. #127

Closed
kartik-pant-23 opened this issue Mar 12, 2021 · 18 comments · Fixed by #345
Closed

Code requires formatting, for readability. #127

kartik-pant-23 opened this issue Mar 12, 2021 · 18 comments · Fixed by #345
Labels
duplicate This issue or pull request already exists unapproved Unapproved, needs to be triaged

Comments

@kartik-pant-23
Copy link

Description
A code that is well formatted with proper indentation in accordance with conventional guidelines, is more readable. Going through the code, I found it as an enhancement, for all of us out there.

Am I doing this?
I have formatted the code and will be making a pull request for the same.

@yasharth291
Copy link
Contributor

#103 please close this issue as it is duplicate of #103

@yasharth291
Copy link
Contributor

@kartik-pant-23

@yasharth291
Copy link
Contributor

and you should close your pr as well because it has merge conflicts.

@kartik-pant-23
Copy link
Author

I have formatted the code and probably i was on different branch while working, which seems to bring those conflicts. Adding comments and refactoring the indentations, doesn't seem similar though.

@yasharth291
Copy link
Contributor

it is same as making code easy to understand. It is duplicate of #103

@kartik-pant-23
Copy link
Author

Are you one of the maintainers? Can you guide me how to go about the missing files in master branch. I was on a different branch while making the pull request, which caused conflicts.

@yasharth291
Copy link
Contributor

please read the issues before i am mentioning the issue about it #92

@kartik-pant-23
Copy link
Author

Thank you.

@yasharth291
Copy link
Contributor

now you can close this issue as it is duplicate and you can delete the pr as well. You have to wait till #92 is closed

@EmperorYP7
Copy link

EmperorYP7 commented Mar 12, 2021

@yasharth291 OMG chill out! 😆

@yasharth291
Copy link
Contributor

@EmperorYP7 it is creating spam issues 👍🏻

@kartik-pant-23
Copy link
Author

PR has been closed, because it was having issues with the current codebase

@yasharth291
Copy link
Contributor

ok thanks for cooperation

@kartik-pant-23
Copy link
Author

Thanks to you for helping like a maintainer.

@yasharth291
Copy link
Contributor

yasharth291 commented Mar 12, 2021

no problem but i am not maintainer xD

i liked the way you are being sarcastic

@kartik-pant-23
Copy link
Author

Glad you understood, can totally understand this enthusiasm.

@DeltaHarbinger
Copy link
Contributor

Hey @kartik-pant-23, we recently merged #151 which includes a number of fixes on the master branch. Everyone seems to be able to build now. I agree with your analysis that a lot of the code isn't formatted properly, so feel free to pull the major changes on master and make a pull request with any changes related to this issue.

@DeltaHarbinger DeltaHarbinger added discussion duplicate This issue or pull request already exists labels Mar 14, 2021
@palisadoes palisadoes added the unapproved Unapproved, needs to be triaged label Mar 16, 2021
@Sagar2366
Copy link
Contributor

Closing this issue as duplicate of #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists unapproved Unapproved, needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants