-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code requires formatting, for readability. #127
Comments
and you should close your pr as well because it has merge conflicts. |
I have formatted the code and probably i was on different branch while working, which seems to bring those conflicts. Adding comments and refactoring the indentations, doesn't seem similar though. |
it is same as making code easy to understand. It is duplicate of #103 |
Are you one of the maintainers? Can you guide me how to go about the missing files in master branch. I was on a different branch while making the pull request, which caused conflicts. |
please read the issues before i am mentioning the issue about it #92 |
Thank you. |
now you can close this issue as it is duplicate and you can delete the pr as well. You have to wait till #92 is closed |
@yasharth291 OMG chill out! 😆 |
@EmperorYP7 it is creating spam issues 👍🏻 |
PR has been closed, because it was having issues with the current codebase |
ok thanks for cooperation |
Thanks to you for helping like a maintainer. |
no problem but i am not maintainer xD i liked the way you are being sarcastic |
Glad you understood, can totally understand this enthusiasm. |
Hey @kartik-pant-23, we recently merged #151 which includes a number of fixes on the master branch. Everyone seems to be able to build now. I agree with your analysis that a lot of the code isn't formatted properly, so feel free to pull the major changes on master and make a pull request with any changes related to this issue. |
Closing this issue as duplicate of #103 |
Description
A code that is well formatted with proper indentation in accordance with conventional guidelines, is more readable. Going through the code, I found it as an enhancement, for all of us out there.
Am I doing this?
I have formatted the code and will be making a pull request for the same.
The text was updated successfully, but these errors were encountered: